feat: Make MAX_NET_DETUNING in AHS device capabilities optional and extend field validator utility functions. #272
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 4141 4159 +18
Branches 429 437 +8
=========================================
+ Hits 4141 4159 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # exceeding MAX_NET_DETUNING at a time point | ||
| return program | ||
|
|
||
|
|
There was a problem hiding this comment.
Just want to remind myself, are these four functions the only things that needs to be moved from the service side to the client side? Also it maybe good to comment on the top of each of these functions that they are only for device emulator and not for AHS local simulator [so that people won't be confused that why they are not used in this repo].
There was a problem hiding this comment.
Actually, don't we also need "validate_pattern_precision"?
There was a problem hiding this comment.
validate_pattern_precision is never used by the Device validators so I chose not to bring it over to the Default Simulator repo.
There was a problem hiding this comment.
Adding the additional comments makes sense for explaining the use of these helpers!
Added copyright notice and licensing information to the test file.
4 participants
Issue #, if available:
Description of changes:
Make the MAX_NET_DETUNING device capability data point optional for AHS program validation - this is done so the Program validator used for AHS programs with the local simulator can also be used with capabilities derived from QPU capabilities, which don't provide a MAX_NET_DETUNING data point.
Additionally, utility methods
validate_max_absolute_slope,validate_time_precision,validate_time_separation,validate_value_precisionare added to field validator utilities for use AHS Program validation with Device Capabilities Constants (introduced in BDK).Testing done:
Tested the newly introduced field validation utility functions.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.